Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PWGHF] fix typo and remove collision index from candidate table in Tcc tree creator #9473

Merged
merged 5 commits into from
Jan 24, 2025
Merged

[PWGHF] fix typo and remove collision index from candidate table in Tcc tree creator #9473

merged 5 commits into from
Jan 24, 2025
+9 −12

Conversation

zhangbiao-phy
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added the pwghf PWG-HF label Jan 23, 2025
@zhangbiao-phy zhangbiao-phy changed the title [PWGHF] fix the missing of candidate table reserve [PWGHF] remove collision index on the standalone derived table Jan 23, 2025
@zhangbiao-phy zhangbiao-phy changed the title [PWGHF] remove collision index on the standalone derived table [PWGHF] remove collision index in the standalone derived table Jan 23, 2025
@zhangbiao-phy zhangbiao-phy changed the title [PWGHF] remove collision index in the standalone derived table [PWGHF] fix typo and remove collision index in the standalone derived table Jan 23, 2025
@zhangbiao-phy zhangbiao-phy marked this pull request as ready for review January 23, 2025 13:46
@zhangbiao-phy zhangbiao-phy enabled auto-merge (squash) January 23, 2025 13:46
alibuild
alibuild previously approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @zhangbiao-phy.

@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for 40f3910 at 2025-01-23 14:58:

[675/2169] Building CXX object PWGEM/Dilepton/Tasks/CMakeFiles/O2Physicsexe-analysis-em-efficiency-ee.dir/emEfficiencyEE.cxx.o
[676/2169] Building CXX object PWGEM/Tasks/CMakeFiles/O2Physicsexe-analysis-em-phos-cell-q-a.dir/phosCellQA.cxx.o
[677/2169] Building CXX object PWGEM/Dilepton/TableProducer/CMakeFiles/O2Physicsexe-analysis-em-skimmer-secondary-electron.dir/skimmerSecondaryElectron.cxx.o
[678/2169] Building CXX object PWGEM/PhotonMeson/Tasks/CMakeFiles/O2Physicsexe-analysis-em-check-mc-v0.dir/CheckMCV0.cxx.o
[679/2169] Building CXX object PWGEM/PhotonMeson/TableProducer/CMakeFiles/O2Physicsexe-analysis-em-skimmer-gamma-calo.dir/skimmerGammaCalo.cxx.o
[680/2169] Linking CXX executable stage/bin/o2-analysis-em-phos-cell-q-a
[681/2169] Linking CXX executable stage/bin/o2-analysis-em-efficiency-ee
[682/2169] Building CXX object PWGEM/PhotonMeson/TableProducer/CMakeFiles/O2Physicsexe-analysis-em-create-emevent-photon.dir/createEMEventPhoton.cxx.o
[683/2169] Building CXX object PWGEM/Dilepton/TableProducer/CMakeFiles/O2Physicsexe-analysis-em-skimmer-primary-electron.dir/skimmerPrimaryElectron.cxx.o
[684/2169] Linking CXX executable stage/bin/o2-analysis-em-skimmer-secondary-electron
[685/2169] Building CXX object PWGEM/PhotonMeson/TableProducer/CMakeFiles/O2Physicsexe-analysis-em-produce-meson-calo.dir/produceMesonCalo.cxx.o
[686/2169] Linking CXX executable stage/bin/o2-analysis-em-check-mc-v0
[687/2169] Linking CXX executable stage/bin/o2-analysis-em-skimmer-gamma-calo
[688/2169] Linking CXX executable stage/bin/o2-analysis-em-create-emevent-photon
[689/2169] Linking CXX executable stage/bin/o2-analysis-em-produce-meson-calo
[690/2169] Linking CXX executable stage/bin/o2-analysis-em-skimmer-primary-electron
[691/2169] Building CXX object PWGEM/PhotonMeson/TableProducer/CMakeFiles/O2Physicsexe-analysis-em-create-pcm.dir/createPCM.cxx.o
[692/2169] Building CXX object PWGEM/PhotonMeson/TableProducer/CMakeFiles/O2Physicsexe-analysis-em-skimmer-gamma-conversion.dir/skimmerGammaConversion.cxx.o
[693/2169] Building CXX object PWGDQ/Tasks/CMakeFiles/O2Physicsexe-analysis-dq-table-reader-with-assoc.dir/tableReader_withAssoc.cxx.o
[694/2169] Building CXX object PWGEM/Tasks/CMakeFiles/O2Physicsexe-analysis-em-phos-trig-q-a.dir/phosTrigQA.cxx.o
[695/2169] Linking CXX executable stage/bin/o2-analysis-em-create-pcm
[696/2169] Building CXX object PWGEM/PhotonMeson/TableProducer/CMakeFiles/O2Physicsexe-analysis-em-gamma-table-producer.dir/gammaSelection.cxx.o
[697/2169] Linking CXX executable stage/bin/o2-analysis-em-skimmer-gamma-conversion
[698/2169] Linking CXX executable stage/bin/o2-analysis-em-phos-trig-q-a
[699/2169] Linking CXX executable stage/bin/o2-analysis-em-gamma-table-producer
[700/2169] Linking CXX executable stage/bin/o2-analysis-dq-table-reader-with-assoc
[701/2169] Building CXX object PWGEM/PhotonMeson/TableProducer/CMakeFiles/O2Physicsexe-analysis-em-photon-conversion-builder.dir/photonconversionbuilder.cxx.o
[702/2169] Building CXX object PWGEM/Tasks/CMakeFiles/O2Physicsexe-analysis-em-phos-calibration.dir/phosCalibration.cxx.o
[703/2169] Building CXX object PWGEM/PhotonMeson/TableProducer/CMakeFiles/O2Physicsexe-analysis-em-associate-mc-info-photon.dir/associateMCinfoPhoton.cxx.o
[704/2169] Building CXX object PWGEM/Tasks/CMakeFiles/O2Physicsexe-analysis-em-phos-clu-q-a.dir/phosCluQA.cxx.o
[705/2169] Linking CXX executable stage/bin/o2-analysis-em-photon-conversion-builder
[706/2169] Linking CXX executable stage/bin/o2-analysis-em-phos-calibration
[707/2169] Linking CXX executable stage/bin/o2-analysis-em-associate-mc-info-photon
[708/2169] Building CXX object PWGEM/PhotonMeson/TableProducer/CMakeFiles/O2Physicsexe-analysis-em-skimmer-dalitz-ee.dir/skimmerDalitzEE.cxx.o
[709/2169] Linking CXX executable stage/bin/o2-analysis-em-phos-clu-q-a
[710/2169] Linking CXX executable stage/bin/o2-analysis-em-skimmer-dalitz-ee
[711/2169] Building CXX object PWGEM/Tasks/CMakeFiles/O2Physicsexe-analysis-em-phos-align.dir/phosAlign.cxx.o
[712/2169] Building CXX object PWGEM/PhotonMeson/TableProducer/CMakeFiles/O2Physicsexe-analysis-em-skimmer-primary-electron-from-dalitzee.dir/skimmerPrimaryElectronFromDalitzEE.cxx.o
[713/2169] Linking CXX executable stage/bin/o2-analysis-em-phos-align
[714/2169] Building CXX object PWGDQ/TableProducer/CMakeFiles/O2Physicsexe-analysis-dq-table-maker-mc.dir/tableMakerMC.cxx.o
[715/2169] Linking CXX executable stage/bin/o2-analysis-em-skimmer-primary-electron-from-dalitzee
[716/2169] Building CXX object PWGEM/Tasks/CMakeFiles/O2Physicsexe-analysis-em-phos-nbar.dir/phosNbar.cxx.o
[717/2169] Linking CXX executable stage/bin/o2-analysis-dq-table-maker-mc
[718/2169] Linking CXX executable stage/bin/o2-analysis-em-phos-nbar
[719/2169] Building CXX object PWGHF/TableProducer/CMakeFiles/O2Physicsexe-analysis-hf-refit-pv-dummy.dir/refitPvDummy.cxx.o
[720/2169] Building CXX object PWGDQ/Tasks/CMakeFiles/O2Physicsexe-analysis-dq-table-reader.dir/tableReader.cxx.o
[721/2169] Building CXX object PWGEM/Tasks/CMakeFiles/O2Physicsexe-analysis-em-phos-el-id.dir/phosElId.cxx.o
[722/2169] Linking CXX executable stage/bin/o2-analysis-hf-refit-pv-dummy
[723/2169] Building CXX object PWGEM/Dilepton/TableProducer/CMakeFiles/O2Physicsexe-analysis-em-filter-dielectron-event.dir/filterDielectronEvent.cxx.o
[724/2169] Building CXX object PWGHF/TableProducer/CMakeFiles/O2Physicsexe-analysis-hf-pid-creator.dir/pidCreator.cxx.o

Full log here.

@alibuild alibuild mentioned this pull request Jan 23, 2025
Closed
@zhangbiao-phy zhangbiao-phy enabled auto-merge (squash) January 23, 2025 17:09
alibuild
alibuild approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @zhangbiao-phy.

@vkucera vkucera disabled auto-merge January 23, 2025 17:21
@vkucera
Copy link
Collaborator

vkucera commented Jan 23, 2025

@zhangbiao-phy Please give the PR a more specific title. From the current one it is not possible to tell which analyses or files are concerned.

@zhangbiao-phy zhangbiao-phy enabled auto-merge (squash) January 23, 2025 18:32
alibuild
alibuild approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @zhangbiao-phy.

@zhangbiao-phy zhangbiao-phy changed the title [PWGHF] fix typo and remove collision index in the standalone derived table [PWGHF] fix typo and remove collision index from candidate table in Tcc tree creator Jan 23, 2025
@vkucera vkucera disabled auto-merge January 23, 2025 22:15
@vkucera vkucera enabled auto-merge (squash) January 23, 2025 22:16
@vkucera
Copy link
Collaborator

vkucera commented Jan 23, 2025

You need to change the title first and then enable auto-merge for the change to take effect.

@zhangbiao-phy
Copy link
Collaborator Author

You need to change the title first and then enable auto-merge for the change to take effect.

I know, but I don't

@vkucera
Copy link
Collaborator

vkucera commented Jan 23, 2025

You need to change the title first and then enable auto-merge for the change to take effect.

I know, but I don't

What do you mean?

@zhangbiao-phy
Copy link
Collaborator Author

You need to change the title first and then enable auto-merge for the change to take effect.

I know, but I don't

What do you mean?

I mean I just realized that after I had already done it. Thank you so much for pointing out this and helping me correct it!

@vkucera vkucera merged commit 590ed38 into AliceO2Group:master Jan 24, 2025
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alibuild alibuild alibuild approved these changes

@vkucera vkucera Awaiting requested review from vkucera vkucera is a code owner

@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner

@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa is a code owner

@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner

@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner

@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner

@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner

@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner

@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner

@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner

@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner

Assignees
No one assigned
Labels
pwghf PWG-HF
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhangbiao-phy @alibuild @vkucera